-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/162/add wallet endpoints #239
Conversation
Signed-off-by: Moriarty <[email protected]>
TODO: * refactor and rename a a few things Signed-off-by: Moriarty <[email protected]>
d02d78c
to
2583dfa
Compare
@blu3beri I need to go over a few things still mainly the naming of some vars and the help strings. I'll tag you when done, but feel free to leave comments otherwise (but be aware it's unfinished) |
Thanks for the contribution @morrieinmaas! Was there a specific reason why you needed this, or just resolving some of the open issues? |
TBH a mix of reasons. as you (correctly) suggested closing open issues, wanted to not get rusty/rustier in Rust and train being rusty... other reasons... and also thought that since there is an intention to wrap the entire cloud agent eventually, which would be quite handy to have thought this was an alright step to take in that direction. Also was sat on a train for 2 hours the other day so I thought this was a nice pastime. |
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nit picks (I assume every endpoint and all options work).
I think it would be good to, somewhere in the future, do a small rewrite for modules. It is getting a bit messy everywhere and we are doing some odd things.
Sure, if you explain a bit what you have in mind I'm happy to help |
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
closes #162